-
Notifications
You must be signed in to change notification settings - Fork 106
Enable AOF #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AOF #255
Conversation
Odd, running tests with @rafie @MeirShpilraien does this ring a bell? |
@lantiga I see that you are getting the env on the test function and then create it (again) at the test itself. This actually cause 2 env's to be created at your test and then undefined behavior (when I say undefined I mean that I did not check what might happened in this case). This way for example you can create a test that run both on single shard and with slave by just writing the test generically and then run it twice, one with the --use-slave argument and one without. On the other hand you might want your test to run only with slave and then you need to not receive the env as an argument and just create it inside the test the way you want. Hope it was clear enough, let me know if it helped. |
@MeirShpilraien thank you for your answer, that clears it. When I saw the env as an argument, I thought there would be a way to augment the incoming environment with programmatically set arguments. At this point I would rather rely on command-line arguments, so we can execute the same tests in different situations. |
… env configurations.
Looking for a review, then ready to merge |
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so --use-slaves ;\ | ||
python3 -m RLTest $(TEST_ARGS) --test double-panda.py --module $(INSTALL_DIR)/redisai.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was failing on macOS, so this line actually waits for the macOS CI to be enabled. If we're convinced that everything is in order there, we can remove the rest of the test artifacts. Otherwise, it may be worthwhile to just comment it out until CI is ready.
@K-Jo FYI I updated the pack version here |
With #157 having been merged, this PR enables AOF and runs the test suite with both RDB and AOF persistence.
TODO: activate AOF tests in CI